Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with Swift 5.2 #91

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix compatibility with Swift 5.2 #91

merged 1 commit into from
Apr 25, 2020

Conversation

andrewchang-bird
Copy link
Contributor

  • Access level for extended members returned by SourceKit are no longer explicitly marked as internal
  • Remove memory address printing for types matched by reference due to bad invocation error when handling optional strings
  • Generate generically overloaded methods wrapped in #if swift(>=5.2)

@andrewchang-bird andrewchang-bird mentioned this pull request Apr 23, 2020
Merged
@andrewchang-bird
Fix compatibility with Swift 5.2
a45b6f1 
- Access level for extended members returned by SourceKit are no longer
  explicitly marked as `internal`
- Remove memory address printing for types matched by reference due to
  bad invocation error when handling optional strings
- Generate generically overloaded methods wrapped in `#if swift(>=5.2)`
@andrewchang-bird andrewchang-bird merged commit abedcd4 into typealiased:master Apr 25, 2020
@andrewchang-bird andrewchang-bird deleted the fix-swift5_2 branch April 25, 2020 21:22
@andrewchang-bird andrewchang-bird added this to the Release 0.12 milestone Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmeisters ryanmeisters ryanmeisters approved these changes

@shackley shackley Awaiting requested review from shackley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewchang-bird @ryanmeisters