Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getOwner example #1546

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

asakusuma
Copy link

getOwner can now return undefined. This change updates the example code to better reflect the current types. See https://github.com/emberjs/ember.js/blob/d7b3f9d95a5bd2619c2762ffda6fbd0b57185cb4/packages/%40ember/-internals/owner/index.ts#L64-L69

Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💙

@chriskrycho chriskrycho enabled auto-merge January 17, 2023 18:47
@chriskrycho chriskrycho disabled auto-merge January 19, 2023 16:13
@chriskrycho
Copy link
Member

CI issues are definitely unrelated.

@chriskrycho chriskrycho merged commit c5881e8 into typed-ember:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants