Auto Imports, remove JS/TS config #677
Conversation
|
Update: got auto-complete working in both .ts and .gts with default TS engine disabled. 
Going to spend some time unifying the text preview to make it clearer what kind of completion/import it is. |
|
Pushed some updates that greatly improve the default formatting of auto imports. 
|
machty
changed the title
machty
changed the title
|
I think this PR is probably ready for a review. Here's how things ended up: 
I do see one issue though: 
For some reason the auto imports don't kick in depending on where you are in the tag... not sure if worth fixing in this PR or a separate issue. |
| @@ -17,3 +17,43 @@ Glint is a family of packages which all live in this repo as a Yarn workspace. T | |||
| - Read the project’s [ARCHITECTURE.md](./ARCHITECTURE.md) to understand the basics of how the code base works. | |||
|
|
|||
| Once you have made changes and added tests to confirm they work correctly, you can then open a PR and we'll work with you to polish it up and get it landed! | |||
|
|
|||
There was a problem hiding this comment.
Thanks a ton for adding this! This is all the information i got super stuck on not having when i was first getting in to glint!
Very needed!
There was a problem hiding this comment.
Thanks a ton for adding tests!!
machty
force-pushed
the
machty-auto-import
branch
from
1e8bbc3
to
918cb33
Compare
|
This is great! Thanks for adding this <3 |
See #130
Basic Support for Auto-Import (for all supported filetypes, including .gts)
You are now offered code completions for auto-imports, and selecting them will add the import at the top of the file.
Remove JS/TS configuration options
Previously we were attempting to read the JS/TS VScode configuration preferences in order to pass them through to the VS LSP within Glint, but since the goal is feature parity with the TS LSP such that you can (and should) disable the default TS LSP, we can't continue to use the default JS/TS config options because they get disabled then you disable the TS built-in extension. This PR replaces them with sensible hard-wired defaults, and we can consider adding configurable VS code preferences specific to Glint in a future PR.
Add localhost dev/debug instructions to CONTRIBUTING.md
This would have been very helpful for me getting up and running.
(Won't fix) Completions don't work on unclosed tags within
<template>Likely not fixable until we have some syntax-forgiving Glimmer parser.