Upgrade to Mypy 1.0 #1360
Merged
Upgrade to Mypy 1.0 #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Is there a reason this is still in draft? |
|
Nope! Just didn't notice that CI passed. ✅ |
ljodal
reviewed
Feb 7, 2023
| @@ -31,7 +31,7 @@ def find_stub_files(name: str) -> List[str]: | |||
| ] | |||
|
|
|||
| extras_require = { | |||
| "compatible-mypy": ["mypy>=0.991,<1.0"], | |||
| "compatible-mypy": ["mypy>=1.0,<1.1"], | |||
There was a problem hiding this comment.
Do we need to bump the minimum, or is that the policy? Seems like there's no braking changes here?
There was a problem hiding this comment.
This only affects those that use django-stubs[compatible-mypy], yes we bump lower bound in that case.
There was a problem hiding this comment.
Ah right, nvm me, I'm blind 😇
|
Nice one! |
|
Nice! Is there a new release planned? |
|
@noamcohen97 See #1363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Upgrade to Mypy 1.0
Related issues
Refs python/mypy#13685