Version 4.2.0 release (django-stubs, django-stubs-ext) #1458
Conversation
README.md
Outdated
| | 0.12.x | old semantic analyzer (<0.711), dmypy support | 2.1.x | ^3.6 | ||
| | django-stubs | mypy version | django version | python version | ||
| |--------------|--------------|----------------------------------| ---- | | ||
| | 4.2.0 | 1.2.x | 3.2.x or 4.0.x or 4.1.x or 4.2.x | ^3.7 |
There was a problem hiding this comment.
Maybe like this?
| | 4.2.0 | 1.2.x | 3.2.x or 4.0.x or 4.1.x or 4.2.x | ^3.7 | |
| | 4.2.0 | 1.2.x | 4.2.x (other versions are partly supported) | ^3.8 |
Note that we don't support 3.7 anymore.
There was a problem hiding this comment.
Note that we don't support 3.7 anymore.
I just removed testing with Python 3.7, but we're still fully compatible Python 3.7.
I want to write in release notes that this is the last django-stubs that works with Python 3.7, and drop it officially after that.
There was a problem hiding this comment.
But, django says:
Django 4.2 supports Python 3.8, 3.9, 3.10, and 3.11. We highly recommend and only officially support the latest release of each series.
In my opinion, it is better to raise this contraint. Otherwise, people might think that 3.7 + 4.2 is supported.
There was a problem hiding this comment.
Yes, but django-stubs doesn't require Django 4.2. As you note, older Django versions are "partly supported".
People may still be using django-stubs with Django 3.2 and Python 3.7. And continuing to support this for one release doesn't require us to do any extra work.
There was a problem hiding this comment.
As for "4.2.x (other versions are partly supported)", maybe we should still list Django versions that our CI is testing with? So maybe add a new column "Django partial support" that lists "4.1, 4.0, 3.2"?
There was a problem hiding this comment.
Because if we ever need to do a hard break in Django compatibility, this would be a good way to communicate that.
There was a problem hiding this comment.
I am going to insist on removing 3.7 though:
- It is 2 month before sunsetting
- It is not tested anymore (so any commit might break this support)
- Some django versions do not support it
- It is not very popular among our users
There was a problem hiding this comment.
It is 2 month before sunsetting
So it's still supported by upstream.
It is not tested anymore (so any commit might break this support)
Yes, but I want to make this release right away when we get this over with. I'm not merging any new commits between now and the release.
It is not very popular among our users
It's over 5%, seems significant to me.
| | 4.2.0 | 1.2.x | 4.2 | 4.1, 4.0, 3.2 | 3.7 - 3.11 | | ||
| | 1.16.0 | 1.1.x | 4.1 | 4.0, 3.2 | 3.7 - 3.11 | | ||
| | 1.15.0 | 1.0.x | 4.1 | 4.0, 3.2 | 3.7 - 3.11 | | ||
| | 1.14.0 | 0.990+ | 4.1 | 4.0, 3.2 | 3.7 - 3.11 | |
There was a problem hiding this comment.
Does this look good to you now? Should I go ahead with the release?
|
Sorry, one question, what do you mean with "partial support" even? We need to stick with Django 3.2 for now, so does it now make sense to go down to a version that does not say "partial support" or is it still best to use the latest version? |
|
The changes between major Django versions aren't that big. I think you're better off upgrading, because When you experience mypy errors due to differences between Django versions, I think |
Related issues