Skip to content

Commit

Permalink
Fix HyperlinkedRelatedField.get_object() argument types (#597)
Browse files Browse the repository at this point in the history
* Fix `HyperlinkedRelatedField.get_object()` argument types

Upstream typehints this method as `def get_object(self, view_name, view_args, view_kwargs)`

* Fix allowlist too
  • Loading branch information
intgr authored Apr 24, 2024
1 parent 9d25503 commit e0ec43f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion rest_framework-stubs/relations.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class HyperlinkedRelatedField(RelatedField[_MT, str, Hyperlink]):
lookup_url_kwarg: str | None = ...,
format: str | None = ...,
) -> None: ...
def get_object(self, view_name: str, *view_args: Any, **view_kwargs: Any) -> _MT: ...
def get_object(self, view_name: str, view_args: list[Any], view_kwargs: dict[str, Any]) -> _MT: ...
def get_url(self, obj: Model, view_name: str, request: Request, format: str | None) -> str | None: ...

class HyperlinkedIdentityField(HyperlinkedRelatedField): ...
Expand Down
2 changes: 0 additions & 2 deletions scripts/stubtest/allowlist_todo.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ rest_framework.pagination.HtmlContext
rest_framework.pagination.HtmlContextWithPageLinks
rest_framework.parsers.BaseParser.media_type
rest_framework.parsers.FileUploadParser.get_encoded_filename
rest_framework.relations.HyperlinkedRelatedField.get_object
rest_framework.relations.ManyRelatedField.initial
rest_framework.relations.ManyRelatedField.to_representation
rest_framework.relations.SlugRelatedField.to_representation
Expand Down Expand Up @@ -91,7 +90,6 @@ rest_framework.serializers.DateField.to_internal_value
rest_framework.serializers.DateTimeField.to_internal_value
rest_framework.serializers.DictField.initial
rest_framework.serializers.DurationField.to_internal_value
rest_framework.serializers.HyperlinkedRelatedField.get_object
rest_framework.serializers.ListField.initial
rest_framework.serializers.ListField.to_representation
rest_framework.serializers.ListSerializer.is_valid
Expand Down

0 comments on commit e0ec43f

Please sign in to comment.