Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: OrderingFilter.get_default_ordering() may return None #379

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix: OrderingFilter.get_default_ordering() may return None #379

merged 1 commit into from
Mar 21, 2023

Conversation

albertocerrone
Copy link
Contributor

Why

def get_default_ordering() could return a None value in case ordering not be included in the view.

image

Related issues

@intgr intgr changed the title fix: Update OrderingFilter get_default_ordering Fix: OrderingFilter.get_default_ordering() may return None Mar 21, 2023
intgr
intgr approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks correct.

@intgr intgr merged commit 1467ae6 into typeddjango:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertocerrone @intgr