CI: Run tests daily to detect incompatible django-stubs changes #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Apr 24, 2024
|
The next step is to open issues when it fails: see https://github.com/python/typeshed/blob/29db988c0a7c7784782fd28e2e250ba852e3fb72/.github/workflows/daily.yml#L131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Motivated by examples like #518, #508 and many others. It happens every few weeks that a change in
django-stubsalso requires followup changes indjangorestframework-stubs.Currently, I only find out when someone opens a PR against DRF-stubs and then CI fails. Having scheduled CI would help me be more proactive about these.
Alternatively, we could also change
django-stubsCI to automatically triggerworkflow_dispatchin DRF-stubs repo on every merge to master. But that would have more moving parts. I think daily schedule is good enough for the time being.