Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pattern[str] for RegexField #539

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Use Pattern[str] for RegexField #539

merged 2 commits into from
Mar 4, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 8, 2024

The underlying django validators requires Pattern[str]

@Viicos Viicos changed the title Use Pattern[str] for `RegexField Use Pattern[str] for RegexField Feb 8, 2024
sobolevn
sobolevn approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 8bb07e4 into typeddjango:master Mar 4, 2024
12 checks passed
@Viicos Viicos deleted the patch-1 branch March 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @sobolevn