fix: wait until primary is transitioned from secondary for replicaSet

typegoose · Jul 23, 2019 · 596fed8 · 596fed8
1 parent ba02479
commit 596fed8
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 15 deletions.
diff --git a/packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts b/packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts
@@ -173,9 +173,9 @@ export default class MongoMemoryReplSet extends EventEmitter {
       const server = this._startServer(this.getInstanceOpts({}));
       servers.push(server);
     }
+    // ensures all servers are listening for connection
+    await Promise.all(servers.map((s) => s.start()));
     this.servers = servers;
-    // Brief delay to wait for servers to start up.
-    await new Promise((resolve) => setTimeout(resolve, 1000));
     await this._initReplSet();
   }
 
@@ -251,7 +251,7 @@ export default class MongoMemoryReplSet extends EventEmitter {
 
   _startServer(instanceOpts: MongoMemoryInstancePropT): MongoMemoryServer {
     const serverOpts: MongoMemoryServerOptsT = {
-      autoStart: true,
+      autoStart: false,
       debug: this.opts.debug,
       binary: this.opts.binary,
       instance: instanceOpts,
@@ -265,13 +265,18 @@ export default class MongoMemoryReplSet extends EventEmitter {
     if (!this.admin) {
       return false;
     }
-    const replStatus: ReplStatusResultT = await this.admin.command({ replSetGetStatus: 1 });
+    const replStatus: ReplStatusResultT = await this.admin.command({
+      serverStatus: 1,
+      metrics: 0,
+      locks: 0,
+    });
     this.debug('   replStatus:', replStatus);
-    const hasPrimary = replStatus.members.some((m) => m.stateStr === 'PRIMARY');
+    const hasPrimary = replStatus.repl.ismaster;
     if (!hasPrimary) {
       this.debug('No PRIMARY yet. Waiting...');
-      return new Promise((resolve) => setTimeout(() => resolve(this._waitForPrimary()), 1000));
+      return new Promise((resolve) => setTimeout(() => resolve(this._waitForPrimary()), 500));
     }
+
     return true;
   }
 }
diff --git a/packages/mongodb-memory-server-core/src/__tests__/replset-test.ts b/packages/mongodb-memory-server-core/src/__tests__/replset-test.ts
@@ -1,4 +1,5 @@
 import MongoMemoryReplSet from '../MongoMemoryReplSet';
+import { MongoClient } from 'mongodb';
 
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 600000;
 
@@ -40,6 +41,16 @@ describe('single server replset', () => {
       setTimeout(resolve, 500);
     });
   });
+
+  it('should be possible to connect replicaset after waitUntilRunning resolveds', async () => {
+    replSet = new MongoMemoryReplSet();
+    await replSet.waitUntilRunning();
+    const uri = await replSet.getUri();
+
+    await MongoClient.connect(`${uri}?replicaSet=testset`, {
+      useNewUrlParser: true,
+    });
+  });
 });
 
 describe('multi-member replica set', () => {
@@ -57,4 +68,15 @@ describe('multi-member replica set', () => {
     const uri = await replSet.getUri();
     expect(uri.split(',').length).toEqual(3);
   }, 40000);
+
+  it('should be possible to connect replicaset after waitUntilRunning resolveds', async () => {
+    const opts: any = { replSet: { count: 3 } };
+    replSet = new MongoMemoryReplSet(opts);
+    await replSet.waitUntilRunning();
+    const uri = await replSet.getUri();
+
+    await MongoClient.connect(`${uri}?replicaSet=testset`, {
+      useNewUrlParser: true,
+    });
+  });
 });
diff --git a/packages/mongodb-memory-server-core/src/types.ts b/packages/mongodb-memory-server-core/src/types.ts
@@ -30,16 +30,10 @@ export interface MongoMemoryInstancePropT extends MongoMemoryInstancePropBaseT {
   storageEngine?: StorageEngineT;
 }
 
-export interface ReplStatusMemberT {
-  _id: number;
-  name: string;
-  health: number;
-  state: number;
-  stateStr: string;
-  uptime: number;
+export interface ReplStatusReplT {
+  ismaster: boolean;
 }
 
 export interface ReplStatusResultT {
-  set: string;
-  members: ReplStatusMemberT[];
+  repl: ReplStatusReplT;
 }