Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Postinstall if "systemBinary" is set #370

Closed
hasezoey opened this issue Sep 10, 2020 · 1 comment · Fixed by #372
Closed

Skip Postinstall if "systemBinary" is set #370

hasezoey opened this issue Sep 10, 2020 · 1 comment · Fixed by #372
Labels
enhancement released Pull Request released | Issue is fixed

Comments

@hasezoey
Copy link
Member

hasezoey commented Sep 10, 2020 •
edited
Loading

Proposed by #225, made into own issue

currently if systemBinary is set, it dosnt skip postinstall
(disable postinstall only in mongodb-memory-server, not the global packages)
This was referenced Sep 10, 2020
Closed
Merged
hasezoey added a commit that referenced this issue Sep 12, 2020
@hasezoey
fix(postinstall): skip postinstall if "SYSTEM_BINARY" is set
34b1f1f 
- skip "mongodb-memory-server"'s postinstall if "SYSTEM_BINARY" is set
- disable eslint-rule "@typescript-eslint/no-var-requires" for all postinstalls

closes #370
@github-actions
Copy link

🎉 This issue has been resolved in version 6.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released Pull Request released | Issue is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(postinstall): skip postinstall if "SYSTEM_BINARY" is set
1 participant
@hasezoey