Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL generation for MongoDB 4.4 #329

Merged
merged 4 commits into from
Aug 2, 2020
Merged

Fix URL generation for MongoDB 4.4 #329

merged 4 commits into from
Aug 2, 2020

Conversation

tinovyatkin
Copy link
Contributor

This PR fixes download URL generation for MongoDB 4.4 for macOS and Windows platforms.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #329 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   78.66%   78.70%   +0.04%     
==========================================
  Files           9        9              
  Lines         928      930       +2     
  Branches      265      268       +3     
==========================================
+ Hits          730      732       +2     
  Misses        196      196              
  Partials        2        2              
Impacted Files Coverage Δ
...ory-server-core/src/util/MongoBinaryDownloadUrl.ts 72.08% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d66264...e4e8530. Read the comment docs.

@hasezoey hasezoey added enhancement Module: Version-String Generation This problem is because of the Version-String Generation (MongoBinaryDownloadUrl) labels Jul 31, 2020
@nodkz nodkz merged commit 9cd80f9 into typegoose:master Aug 2, 2020
@nodkz
Copy link
Collaborator

nodkz commented Aug 2, 2020

@tinovyatkin thanks a lot for code improvements and this fix! 👍

@tinovyatkin tinovyatkin deleted the fix-for-4.4-on-osx branch August 2, 2020 18:16
@SebastienElet
Copy link

@nodkz can we have a release for this one please ? 🙏

@nodkz
Copy link
Collaborator

nodkz commented Aug 17, 2020

@SebastienElet thanks for your message.
Codecov failed on CI 15 days ago. I've just restarted a job and a new version should be published from minute to minute.

@tinovyatkin
Copy link
Contributor Author

tinovyatkin commented Aug 17, 2020

@nodkz FYI, you may switch off codecov commit status for master merging via .codecov.yml:

coverage:
  status:
    project:
      default:
        only_pulls: true
    patch:
      default:
        only_pulls: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Module: Version-String Generation This problem is because of the Version-String Generation (MongoBinaryDownloadUrl)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants