Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some reported issues & change version mongodb-version testing to semver (for windows & osx) #341

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Fix some reported issues & change version mongodb-version testing to semver (for windows & osx) #341

merged 1 commit into from
Aug 24, 2020

Conversation

hasezoey
Copy link
Member

@hasezoey hasezoey commented Aug 24, 2020 •
edited
Loading

  • fix: change mongodb version tests to use semver (for win32 & windows & osx)
  • fix: add "macos" for 4.2+ and "osx" for 4.1- (bug introduced in 9cd80f9)
  • fix: dont assume "anythingmint" as "mint"
  • move tests for "win32" & "windows" into an "describe"
  • add test for "Peppermint" to not assert to "mint"
  • add dependency "semver" (for more understandable code & better range checking)

Related Issues

@hasezoey
fix: change mongodb version tests to use semver
31183dd 
fix: add "macos" for 4.2+ and "osx" for 4.1-
fix: dont assume "anythingmint" as "mint"

- move tests for "win32" & "windows" into an "describe"
- add test for "Peppermint" to not assert to "mint"
- add dependency "semver"

fixes #340
fix partially #318
@hasezoey hasezoey added the Module: Version-String Generation This problem is because of the Version-String Generation (MongoBinaryDownloadUrl) label Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #341 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   78.70%   78.66%   -0.05%     
==========================================
  Files           9        9              
  Lines         930      928       -2     
  Branches      262      259       -3     
==========================================
- Hits          732      730       -2     
  Misses        197      197              
  Partials        1        1
Impacted Files Coverage Δ
...ory-server-core/src/util/MongoBinaryDownloadUrl.ts 71.79% <100.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14ab81...31183dd. Read the comment docs.

@hasezoey hasezoey mentioned this pull request Aug 24, 2020
Closed
@hasezoey hasezoey merged commit 31183dd into typegoose:master Aug 24, 2020
@hasezoey hasezoey deleted the fixbugs branch August 24, 2020 15:31
@hasezoey hasezoey mentioned this pull request Aug 24, 2020
Closed
@nodkz
Copy link
Collaborator

nodkz commented Aug 24, 2020

Thanks! Great improvements with semver 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Module: Version-String Generation This problem is because of the Version-String Generation (MongoBinaryDownloadUrl)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"failed to download/install MongoDB binaries. The error: Error: Status Code is 403" in v6.6.4 on MacOS
2 participants
@hasezoey @nodkz