Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List latest Ubuntu version #96

Merged
merged 4 commits into from
Oct 26, 2018
Merged

List latest Ubuntu version #96

merged 4 commits into from
Oct 26, 2018

Conversation

YuriGor
Copy link
Contributor

@YuriGor YuriGor commented Oct 25, 2018

#89

@YuriGor YuriGor changed the title List latest Ubuntu version #89 List latest Ubuntu version Oct 25, 2018
@YuriGor
Copy link
Contributor Author

YuriGor commented Oct 26, 2018

May be we need to update default version from 1404 to 1804?
If somebody uses non-lts distro, it most likely will be the latest one,
so chances are the latest mongo will fit better.

@nodkz nodkz merged commit b16d75a into typegoose:master Oct 26, 2018
@nodkz
Copy link
Collaborator

nodkz commented Oct 26, 2018

@YuriGor thanks a lot for PR!

This default value is not so important. It used only when os package cannot determine Ubuntu version.

We may change this in another PR. But for now merge changes, cause it helps to solve the current problem for Ubuntu 18 users.

@nodkz
Copy link
Collaborator

nodkz commented Oct 26, 2018

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nodkz
Copy link
Collaborator

nodkz commented Oct 26, 2018

@AJRdev thanks for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants