Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched megaparsec-7.0.3 #122

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Patched megaparsec-7.0.3 #122

merged 1 commit into from
Nov 3, 2018

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented Nov 3, 2018

  • New version 7.0.x or/and its use in dhall-1.18.0 throws fewer StackOverflow's but still it throws some
  • No support for eta version <= 0.0.9.7, let me know if you think it is still needed
  • Not sure if it is needed to replicate the patch for 7.0.0/1/2

Copy link
Member

@rahulmutt rahulmutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jneira! The work you've done is enough - no need for the other things you suggested.

Btw what do you mean by fewer StackOverflowErrors? You shouldn't be getting them to begin with! Please file an issue on the eta repo detailing the situation.

@rahulmutt rahulmutt merged commit 6fef25b into typelead:master Nov 3, 2018
@jneira
Copy link
Collaborator Author

jneira commented Nov 3, 2018

@rahulmutt dhall throwed the StackOverflow with this input: { name = "dhall", description = "desc", stars = 123 } before the patch, in a similar way it did with simpler inputs in the past (see typelead/eta#704 (comment))
I thought it is normal with parser that uses continuation style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants