Markdown spec compliance: allow URLs with nested parenthesis (#514)

typelevel · Sep 4, 2023 · 88d8b96 · 88d8b96
1 parent a0d9639
commit 88d8b96
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/core/shared/src/main/scala/laika/markdown/InlineParsers.scala b/core/shared/src/main/scala/laika/markdown/InlineParsers.scala
@@ -197,9 +197,12 @@ object InlineParsers {
     def enclosedIn(delim: String): Parser[String] =
       delim ~> delimitedBy(delim <~ lookAhead(titleEnd))
     val title                                     = ws.void ~> (enclosedIn("\"") | enclosedIn("'"))
+    val nestedParens                              = ("(" ~ delimitedBy(')')).source
 
     val url = ("<" ~> text(delimitedBy('>')).embed(recParsers.escapeSequence)) |
-      text(delimitedBy(')', ' ', '\t').keepDelimiter).embed(recParsers.escapeSequence)
+      text(delimitedBy(')', ' ', '\t').keepDelimiter).embedAll(
+        Seq(recParsers.escapeSequence, nestedParens)
+      )
 
     val urlWithTitle =
       ("(" ~> url ~ opt(title) <~ ws ~ ")").mapN(TargetUrl.apply).withCursor.map(t =>

diff --git a/core/shared/src/test/scala/laika/markdown/InlineParsersSpec.scala b/core/shared/src/test/scala/laika/markdown/InlineParsersSpec.scala
@@ -171,6 +171,13 @@ class InlineParsersSpec extends FunSuite with TestSourceBuilders {
     runEnclosed("some [link](http://foo) here", SpanLink.external("http://foo")("link"))
   }
 
+  test("links - inline link with nested parenthesis") {
+    runEnclosed(
+      "some [link](http://foo?param=foo(bar)baz) here",
+      SpanLink.external("http://foo?param=foo(bar)baz")("link")
+    )
+  }
+
   test("links - recognize email link as external link") {
     runEnclosed(
       "some [link](mailto:nobody@nowhere.com) here",