Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RewriteRules should not be a case class #484

Merged
merged 1 commit into from
Aug 11, 2023
Merged

RewriteRules should not be a case class #484

merged 1 commit into from
Aug 11, 2023

Conversation

jenshalm
Copy link
Contributor

@jenshalm jenshalm commented Aug 8, 2023

This type captures partial functions and does not naturally support structural equality.

The copy method is not essential either, as it's a type that is commonly just constructed once and then passed to the Laika setup APIs. If needed, multiple instances can be constructed and combined with ++.

@jenshalm jenshalm added this to the 1.0.0-M3 milestone Aug 8, 2023
@jenshalm jenshalm merged commit fc65b74 into main Aug 11, 2023
21 checks passed
@jenshalm jenshalm deleted the api/rewrite-rules branch August 11, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant