Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce some deprecations to help with migrating to 1.x #518

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

jenshalm
Copy link
Contributor

@jenshalm jenshalm commented Sep 7, 2023

This PR only covers a small subset of the most commonly used APIs which tend to be used in basic build configuration, 1.x changes in lower-level APIs are too much effort to cover. In other words, this PR helps end users, but not so much extension developers.

List of new deprecations (all other deprecations introduced during the 0.19 lifespan should be addressed, too, before attempting to migrate to 1.x):

  • LaikaConfig.encoding -> .withEncoding
  • Helium.site/all/epub/pdf.fontResources -> .addFontResources
  • LinkConfig.apply -> LinkConfig.empty.addXXX(...).addYYY(...)
  • DocumentTree.apply -> DocumentTree.builder.addXXX(...).addYYY(...)

@jenshalm jenshalm added this to the 0.19.4 milestone Sep 7, 2023
@jenshalm jenshalm merged commit 766eeba into 0.19.x Sep 8, 2023
1 check passed
@jenshalm jenshalm deleted the api/deprecations-1.x branch September 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant