Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix perfomance regression in preview server bootstrapping #524

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

jenshalm
Copy link
Contributor

@jenshalm jenshalm commented Sep 11, 2023

The AST rendering capability introduced in 0.19.4 triggered the initialisation of the new feature eagerly during bootstrap causing significantly longer boot times, depending on input size.

This PR makes AST rendering lazy, so that the speed tax is only payed (once) when actually accessing an AST page for the first time. Given that many users will probably not use this functionality, it's essential that it does not affect boot times.

@jenshalm jenshalm added this to the 0.19.5 milestone Sep 11, 2023
@jenshalm jenshalm merged commit a63a035 into 0.19.x Sep 13, 2023
1 check passed
@jenshalm jenshalm deleted the fix/preview-perf branch September 13, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant