preparing repackaging for 1.0 - move ADT members to companion + some more removals from public API #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a grab bag of small changes to prepare for the final repackaging step.
It moves ADT members to the companion for improved scaladoc navigation for the following types:
laika.config.ConfigValuelaika.config.ConfigErrorlaika.rewrite.link.TargetValidationIt moves error types for
laika-corefrom theDocumentParsercompanion to a new packagelaika.api.errorsso that theDocumentParsercan be removed from the public API.It removes the
TreeOutputmodel from public APIs in favor of adding a.toMemorymethod to all transformer builders which removes the need for having the ADT in public.Makes error types in
laika-ioprivate. It's unclear whether there is demand for having access to them. In case there is, it's better to re-introduce them in a 1.x minor as they are in need of some additional polishing.Exposes
NoOpPathTranslatorinPathTranslator.noOpinstead.This is the last PR before a major repackaging PR that addresses the issue of having multiple semi-populated skeleton packages after all the removals from public API in M2.