keep fixing warnings in 'core' #571
Conversation
|
|
||
| def unapply[A](heap: Heap[A]): Boolean = heap.isEmpty | ||
|
|
||
| final private[collections] case class Leaf[A] private () extends Heap[A] { |
There was a problem hiding this comment.
Pretty much the same fix as it was in Diet.scala for the "match may not be exhaustive" warnings.
|
Interesting.. There are no tests reported as failed but rather
|
|
Right, that means the Node.js VM crashed. Maybe one of the generators is making too much data? |
satorg
force-pushed
the
fix-even-more-warns
branch
from
4e0d647
to
4e32c3a
Compare
Actually there was a mistake I made in the However, when I started debugging it I noticed that there are similar issues with |
| // Visit values in range [start, end), i.e. excluding `end`. | ||
| while (order.lt(i, end)) { | ||
| f(i) | ||
| i = discrete.succ(i) | ||
| } | ||
| // Visit the last (or the only) value, if any. | ||
| if (order.eqv(i, end)) | ||
| f(i) |
There was a problem hiding this comment.
The previous implementation was resulting to infinite loops in cases like
Range(123.toByte, Byte.MaxValue).foreach(_ => ())
I.e. due to integer overflows that could not be caught previously.
|
Hmm... not sure, why Mima gets triggered on Moreover, I did pretty much the same trick for |
MiMa has some issues sometimes with private classes inside objects. It should be safe to exclude. |
|
Hmm, I see MiMa is complaining about many things. We've already discussed breaking bincompat in #277 (comment), maybe we should just bump the base version to 1.0? |
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=============================
=============================
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
They are all about But yeah, it is quite weird that we have to have those filters for it after all. The only difference between |
Yes, I've noticed similar behavior too. My guess is that |
For #486 (a follow-up to #569).