explicit disabling of automatic coloring #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Fascinating! Thank you for catching this |
djspiewak
approved these changes
Nov 19, 2022
Baccata
reviewed
Nov 19, 2022
| @@ -31,10 +32,9 @@ object cps { | |||
| transparent inline def await: A = _root_.cps.await[F, A, F](self) | |||
| } | |||
|
|
|||
| implicit def catsEffectCpsMonadPureMemoization[F[_]](implicit F: Concurrent[F]): CpsMonadMemoization.Pure[F] = | |||
There was a problem hiding this comment.
Does memoization has to do with automatic colouring in the context of dotty-cps? If not, any reason not to keep it ?
MiMa is complaining about bincompat, so it's either a case of keeping it, or prepping the version so that the next release is 0.5.0
There was a problem hiding this comment.
In the early days, memoization was needed in some internal interfaces for async but actually called only during automatic coloring.
Now - dotty-cps-async requires a memoization interface only if automatic coloring is enabled.
From another side, we can restore memoization for compatibility, overhead is small.
Baccata
approved these changes
Nov 19, 2022
|
Thank you for this ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason (I'm yet not fully understand this, a bug in dotty or something like this - I will investigate now),
called inside object cats-effect.cps, resolved to
cps.automaticColoring.tageven ifcps.automaticColoring.tagis not imported into the current scope. This trigger an analysing which trigger a message appearing in #98To workaround against this, better explicitly disable automatic coloring by defining two tags. [I remember you don't want one in your use-case].
Regards!