Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added orElse combinator to IO #2940

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Added orElse combinator to IO #2940

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a931cf
Added orElse combinator to IO
Apr 4, 2022
0c7218c
Merge branch 'typelevel:series/3.x' into series/3.x
walesho Apr 4, 2022
ebe93f2
Added orElse combinator to IO
Apr 5, 2022
406841c
Added orElse combinator on IO
Apr 5, 2022
ce8e089
Added orElse combinator to IO
Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/shared/src/main/scala/cats/effect/IO.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ sealed abstract class IO[+A] private () extends IOPlatform[A] {
* @return
*/
def orElse[B >: A](other: IO[B]): IO[B] =
handleErrorWith(_ => other)
SemigroupK[IO].combineK(this, other)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go the other way around: leave this like you had it, and implement SemigroupK in terms of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input. I would follow that approach.


/**
* Handle any error, potentially recovering from it, by mapping it to another `IO` value.
Expand Down