Add fromFutureCancelable
and friends
#3374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to:
async_
to be uncancelable #3205I was working on http4s-dom and encountered roughly this:
The problem is that
fromPromise
is implemented viaasync_
which will be uncancelable under the new semantics. Without afromPromiseCancelable
variant I'd have to re-implement the conversion logic or run it on another fiber, so here we are.Along these lines I also added
fromFutureCancelable
. I did not add a variant forCompletableFuture
because its API natively supports cancelation (go Java! ). As a plus side, these methods offer an escape hatch for anyone who is bitten by the new semantics.The method names and signatures feel a bit unergonomic so definitely open to bikeshed. I didn't try too hard to share implementations since it would also be messy.