Migrate to sbt-typelevel #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 96.56% 96.74% +0.17%
==========================================
Files 9 9
Lines 1049 1106 +57
Branches 94 103 +9
==========================================
+ Hits 1013 1070 +57
Misses 36 36
Continue to review full report at Codecov.
|
armanbilge
commented
Jan 20, 2022
| @@ -5,21 +5,14 @@ import Dependencies._ | |||
| addCommandAlias("fmt", "; scalafmtAll; scalafmtSbt") | |||
| addCommandAlias("fmtCheck", "; scalafmtCheckAll; scalafmtSbtCheck") | |||
|
|
|||
| addCommandAlias("prePR", "; githubWorkflowGenerate ; +fmt; bench/compile; +test") | |||
| tlReplaceCommandAlias("prePR", "; githubWorkflowGenerate ; +fmt; bench/compile; +test") | |||
There was a problem hiding this comment.
sbt-typelevel defines its own prePR so we replace the alias.
Comment on lines
-159
to
-167
| Global / scalaJSStage := FastOptStage, | ||
| parallelExecution := false, | ||
| jsEnv := new org.scalajs.jsenv.nodejs.NodeJSEnv(), | ||
| // batch mode decreases the amount of memory needed to compile scala.js code | ||
| scalaJSLinkerConfig := scalaJSLinkerConfig.value | ||
| .withBatchMode(scala.sys.env.get("TRAVIS").isDefined) | ||
| .withModuleKind(ModuleKind.CommonJSModule), | ||
| coverageEnabled := false, | ||
| scalaJSUseMainModuleInitializer := false |
There was a problem hiding this comment.
Pretty sure these are all redundant.
Comment on lines
-69
to
-76
| ThisBuild / homepage := Some(url("https://github.com/typelevel/cats-parse")) | ||
|
|
||
| ThisBuild / scmInfo := Some( | ||
| ScmInfo( | ||
| url("https://github.com/typelevel/cats-parse"), | ||
| "git@github.com:typelevel/cats-parse.git" | ||
| ) | ||
| ) |
There was a problem hiding this comment.
sbt-typelevel sets this automatically.
johnynek
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the build to sbt-typelevel. It's very similar to sbt-spiewak, so most things are the same. Notable differences:
Since the build here is fairly customized, I've been conservative about adopting additional sbt-typelevel features (e.g., CI matrices crossed on JVM/JS in addition to Scala version).