-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to sbt-typelevel #354
Conversation
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 96.56% 96.74% +0.17%
==========================================
Files 9 9
Lines 1049 1106 +57
Branches 94 103 +9
==========================================
+ Hits 1013 1070 +57
Misses 36 36
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for review. Thanks!
@@ -5,21 +5,14 @@ import Dependencies._ | |||
addCommandAlias("fmt", "; scalafmtAll; scalafmtSbt") | |||
addCommandAlias("fmtCheck", "; scalafmtCheckAll; scalafmtSbtCheck") | |||
|
|||
addCommandAlias("prePR", "; githubWorkflowGenerate ; +fmt; bench/compile; +test") | |||
tlReplaceCommandAlias("prePR", "; githubWorkflowGenerate ; +fmt; bench/compile; +test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt-typelevel defines its own prePR
so we replace the alias.
Global / scalaJSStage := FastOptStage, | ||
parallelExecution := false, | ||
jsEnv := new org.scalajs.jsenv.nodejs.NodeJSEnv(), | ||
// batch mode decreases the amount of memory needed to compile scala.js code | ||
scalaJSLinkerConfig := scalaJSLinkerConfig.value | ||
.withBatchMode(scala.sys.env.get("TRAVIS").isDefined) | ||
.withModuleKind(ModuleKind.CommonJSModule), | ||
coverageEnabled := false, | ||
scalaJSUseMainModuleInitializer := false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure these are all redundant.
ThisBuild / homepage := Some(url("https://github.com/typelevel/cats-parse")) | ||
|
||
ThisBuild / scmInfo := Some( | ||
ScmInfo( | ||
url("https://github.com/typelevel/cats-parse"), | ||
"git@github.com:typelevel/cats-parse.git" | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt-typelevel sets this automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Cc @mpilquist who set up the build.
Migrates the build to sbt-typelevel. It's very similar to sbt-spiewak, so most things are the same. Notable differences:
Since the build here is fairly customized, I've been conservative about adopting additional sbt-typelevel features (e.g., CI matrices crossed on JVM/JS in addition to Scala version).