Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocations from StringIn when returning a string #368

Merged
merged 16 commits into from
Feb 20, 2022
Merged

Remove allocations from StringIn when returning a string #368

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2131202
checkpoint with compiling
johnynek Jan 31, 2022
b4bf30d
refactor merging
johnynek Feb 3, 2022
0d83c4f
use DefiniteString more
johnynek Feb 3, 2022
7cdb219
try to fix tests
johnynek Feb 4, 2022
b19f60d
get 3.0.2 passing
johnynek Feb 4, 2022
853e1a2
fix mima, improve oneOf
johnynek Feb 4, 2022
9b0757d
checkpoint
johnynek Feb 6, 2022
1ed7acd
get tests passing
johnynek Feb 7, 2022
ac5f3aa
more tests, format, mima
johnynek Feb 11, 2022
67a0b56
Merge branch 'main' into oscar/string_in_capture
johnynek Feb 11, 2022
294b4c8
remove unused code
johnynek Feb 11, 2022
dfcf55c
simplify isVoided
johnynek Feb 11, 2022
0b79ad3
cleanup
johnynek Feb 11, 2022
1f5d7f6
add isUnit
johnynek Feb 11, 2022
e24d99f
address review comments
johnynek Feb 13, 2022
4590a69
add non-voided stringIn benchmarks
johnynek Feb 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,18 +135,33 @@ lazy val core = crossProject(JSPlatform, JVMPlatform)
if (isScala211) Set.empty else mimaPreviousArtifacts.value
},
mimaBinaryIssueFilters ++= {
/*
* It is okay to filter anything in Impl or RadixNode which are private
*/
if (tlIsScala3.value)
List(
ProblemFilters.exclude[IncompatibleResultTypeProblem]("cats.parse.Parser#State.error"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("cats.parse.Parser#State.error_="),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("cats.parse.RadixNode.this"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.Parser#Impl.mergeCharIn"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.Parser#Impl.mergeStrIn"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.RadixNode.children"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.RadixNode.fsts"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.RadixNode.prefixes"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.RadixNode.children"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.RadixNode.word"),
ProblemFilters.exclude[FinalClassProblem]("cats.parse.RadixNode")
ProblemFilters.exclude[FinalClassProblem]("cats.parse.RadixNode"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("cats.parse.Parser#State.error_="),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("cats.parse.RadixNode.this"),
ProblemFilters
.exclude[IncompatibleResultTypeProblem]("cats.parse.Parser#Impl#StringIn.parseMut"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("cats.parse.Parser#Impl.stringIn"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("cats.parse.Parser#State.error")
)
else
List(
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.Parser#Impl.mergeCharIn"),
ProblemFilters.exclude[DirectMissingMethodProblem]("cats.parse.Parser#Impl.mergeStrIn"),
ProblemFilters
.exclude[IncompatibleResultTypeProblem]("cats.parse.Parser#Impl#StringIn.parseMut"),
ProblemFilters.exclude[IncompatibleResultTypeProblem]("cats.parse.Parser#Impl.stringIn")
)
else Nil
}
)
.jsSettings(
Expand Down
Loading