Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native build #376

Closed
wants to merge 27 commits into from
Closed

Conversation

i10416
Copy link
Contributor

@i10416 i10416 commented Feb 13, 2022

close #371

Waiting for non-snapshot cats-core_native0.4_3 published which depends on

Now, cats(snapshot version) supports Scala Native x Scala 3

@i10416 i10416 marked this pull request as draft February 13, 2022 09:08
@johnynek
Copy link
Collaborator

looks like you need to run prePR or fmt or something.

@i10416
Copy link
Contributor Author

i10416 commented Mar 18, 2022

follow up #384

i10416 and others added 13 commits March 20, 2022 17:58
* checkpoint with compiling

* refactor merging

* use DefiniteString more

* try to fix tests

* get 3.0.2 passing

* fix mima, improve oneOf

* checkpoint

* get tests passing

* more tests, format, mima

* remove unused code

* simplify isVoided

* cleanup

* add isUnit

* address review comments

* add non-voided stringIn benchmarks
* Update sbt-typelevel to 0.4.6

* Run prePR with sbt-typelevel
@i10416 i10416 force-pushed the build-against-native-platform branch from dda5375 to 80ab15c Compare March 20, 2022 08:58
@i10416
Copy link
Contributor Author

i10416 commented Mar 20, 2022

Hmm, cats-core_native2.11 is not published...🤔

@johnynek
Copy link
Collaborator

can you disable the native build for 2.11?

@i10416
Copy link
Contributor Author

i10416 commented Mar 21, 2022

Yes, of course :)

@i10416
Copy link
Contributor Author

i10416 commented Mar 27, 2022

@armanbilge
Copy link
Member

@i10416 thanks for the heads-up! If you're interested, the plan is to integrate that with sbt-typelevel in typelevel/sbt-typelevel#138.

@johnynek
Copy link
Collaborator

@i10416 I'd like to publish the next version soon. Do you want to try to get the native build ready to be in that release?

@i10416
Copy link
Contributor Author

i10416 commented Mar 28, 2022

@johnynek I am not in a hurry, so feel free to publish the next release😉 I think(or hope) Scala 3.1.2 will be available until the one after the next cats-parse release and I will finish this PR until then.

@i10416
Copy link
Contributor Author

i10416 commented Mar 28, 2022

@armanbilge Thanks! I will take a look at the linked issue.

@armanbilge
Copy link
Member

armanbilge commented Mar 28, 2022

Actually, I think we should forget about Scala 3.0 and update everything to Scala 3.1. Lots of folks seem to agree, including the munit maintainers. Then we don't need to wait for Scala 3.1.2. See:

@i10416
Copy link
Contributor Author

i10416 commented Mar 28, 2022

@armanbilge
Ah, I see. I think that's nice news for most of Scala 3 users, as it unlock downstream libraries. In addition, I guess those who have already adapted Scala 3.x are likely to be Scala power user, willing to update to latest Scala 3.x version.

Btw, I'm a bit busy in April and progress may delay.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #376 (18065c8) into main (fd1d688) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   95.06%   95.14%   +0.07%     
==========================================
  Files           9        9              
  Lines        1338     1338              
  Branches      124      124              
==========================================
+ Hits         1272     1273       +1     
+ Misses         66       65       -1     
Impacted Files Coverage Δ
...shared/src/main/scala/cats/parse/Accumulator.scala 100.00% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1d688...18065c8. Read the comment docs.

@i10416 i10416 force-pushed the build-against-native-platform branch from 459f5cf to bc79463 Compare April 11, 2022 13:04
i10416 added 2 commits April 11, 2022 22:09
cats-parse for scala 2.12 scala native is not released
@i10416 i10416 force-pushed the build-against-native-platform branch 3 times, most recently from 3b537bb to 8d9a790 Compare June 11, 2022 16:14
@i10416 i10416 force-pushed the build-against-native-platform branch from 8d9a790 to 33adb06 Compare June 11, 2022 16:25
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@i10416 i10416 force-pushed the build-against-native-platform branch from 2408e18 to 18065c8 Compare June 11, 2022 16:37
Comment on lines +90 to +102
resolvers ++= Seq(
"Sonatype OSS Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots",
"Sonatype OSS Snapshots s01" at "https://s01.oss.sonatype.org/content/repositories/snapshots"
),
crossScalaVersions := (ThisBuild / crossScalaVersions).value.filterNot(_.startsWith("2.11")),
tlVersionIntroduced := List("2.12", "2.13", "3").map(_ -> "0.3.8").toMap,
libraryDependencies := {
if (scalaVersion.value.startsWith("3.1")) {
libraryDependencies.value.filterNot(_ == Dependencies.cats) ++ Seq(
Dependencies.catsSnapshot.value
)
} else { libraryDependencies.value }
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnynek johnynek closed this Jun 30, 2022
@i10416 i10416 changed the title wip:add native build add native build Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to support Scala Native?
6 participants