Skip to content

Commit

Permalink
Add note about non-master review policy (#3354)
Browse files Browse the repository at this point in the history
  • Loading branch information
travisbrown committed Mar 11, 2020
1 parent 21d49b4 commit e3dc36a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ When fixing typos, improving documentation or minor build fix only
one sign-off is required (although for major edits waiting for two
may be preferable).

In some cases pull requests that don't target the master branch may be
merged with a single sign-off from a maintainer (as long as they
aren't also the author of the pull request). For example, backporting
changes from master to the `scala_2.11` branch generally shouldn't
require multiple reviews. If either the pull request author or a Cats
maintainer thinks that a specific change should receive multiple
approvals even though it doesn't target the master branch, their
request should be respected.

For serious emergencies or work on the build which can't easily be
reviewed or tested, pushing directly to master may be OK (but is
definitely not encouraged). In these cases it's best to comment in
Expand Down

0 comments on commit e3dc36a

Please sign in to comment.