Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a solution for adding new features to cats-kernel avoiding breaking bin-compat. #1879

Open
kailuowang opened this issue Aug 31, 2017 · 4 comments

Comments

@kailuowang
Copy link
Contributor

related #1878 #1712 #1527

@kailuowang
Copy link
Contributor Author

Also we'll probably quickly run into the same question IRT cats-core after 1.0.0. So hopefully the solution we come up with kernel will be a good reference.

@johnynek
Copy link
Contributor

1 think we could do is try to be more aggressive about using abstract class over trait which is kinder on binary compatibility (although that may not be true in scala 2.12 since I think trait encoding changed).

Aside from that, scala is pretty sensitive to binary change (one day, we will live in a source dependency world, I hope...). And we want cats to be at the bottom of a lot of dep graphs, we need a high degree of compatibility.

@kailuowang
Copy link
Contributor Author

good point @johnynek , I am creating a PR to change existing "instance" trait to abstract class.

@kailuowang
Copy link
Contributor Author

removed from RC1 scope, since all breaking changes are okayed by @johnynek representing the Algebird community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants