Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert trait into abstract class for better bin compact #1882

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

kailuowang
Copy link
Contributor

related #1879

@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #1882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1882   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         241      241           
  Lines        4199     4199           
  Branches      106      106           
=======================================
  Hits         3988     3988           
  Misses        211      211
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyList.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/Eval.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyVector.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/OneAnd.scala 98.36% <ø> (ø) ⬆️
core/src/main/scala/cats/data/OptionT.scala 100% <ø> (ø) ⬆️
free/src/main/scala/cats/free/FreeT.scala 91.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85cc86...3dcddf7. Read the comment docs.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ceedubs
Copy link
Contributor

ceedubs commented Sep 8, 2017

Merging since this is a minor documentation fix.

@ceedubs ceedubs merged commit f966c0a into typelevel:master Sep 8, 2017
@ceedubs
Copy link
Contributor

ceedubs commented Sep 8, 2017

Oops this isn't the PR that I meant to merge 😬. I think that it's probably fine though. If anyone has any concerns, please let me know.

@kailuowang
Copy link
Contributor Author

I agree it should be fine.

@kailuowang kailuowang deleted the better-bin branch September 8, 2017 18:44
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants