Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foldA, reduceMapA and reduceA #3141

Closed
LukaJCB opened this issue Nov 12, 2019 · 5 comments
Closed

Add foldA, reduceMapA and reduceA #3141

LukaJCB opened this issue Nov 12, 2019 · 5 comments
Labels
help wanted

Comments

@LukaJCB
Copy link
Member

LukaJCB commented Nov 12, 2019

No description provided.

@Twizty
Copy link
Contributor

Twizty commented Nov 13, 2019

Hi, I'd like to implement it.

@LukaJCB
Copy link
Member Author

LukaJCB commented Nov 13, 2019

Hi @Twizty, go right ahead! You can have a look at #3130 for inspiration and do feel free to ask any questions you might have here or on the gitter channel :)

@Twizty
Copy link
Contributor

Twizty commented Nov 13, 2019

@LukaJCB all these 3 methods should have the same signature as their monadic versions, but instead of Monad[G] they should have Applicative[G]?

@LukaJCB
Copy link
Member Author

LukaJCB commented Nov 13, 2019

Pretty much, yeah :)

Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 14, 2019
@Twizty
typelevel#3141 [WIP] Implemented .foldA
2ce81ea
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 14, 2019
@Twizty
typelevel#3141 [WIP] Implemented .reduceA
ac9efdc
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 14, 2019
@Twizty
typelevel#3141 [WIP] Implemented .reduceMapA
6d28b9c
@travisbrown travisbrown mentioned this issue Nov 14, 2019
Merged
@Twizty Twizty mentioned this issue Nov 14, 2019
Open
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 15, 2019
@Twizty
typelevel#3141 Refactored
f914fb5
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 15, 2019
@Twizty
typelevel#3141 Added tests
aa36227
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 15, 2019
@Twizty
typelevel#3141 Fixed 2.13
ae5a3d7
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 15, 2019
@Twizty
typelevel#3141 Added link to the issue at simulacrum
1ff4848
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 15, 2019
@Twizty
typelevel#3141 Fixed docs
07f8d38
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 18, 2019
@Twizty
typelevel#3141 Formatted
d59858a
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 18, 2019
@Twizty
typelevel#3141 Refactored
619b1b4
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 18, 2019
@Twizty
typelevel#3141 Changed .reduceMap signature
c910cea
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 19, 2019
@Twizty
typelevel#3141 Removed noop on .reduceMapA
82c16e1
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 19, 2019
@Twizty
typelevel#3141 Fixed docs
6eebfeb
Twizty added a commit to EpamLifeSciencesTeam/cats that referenced this issue Nov 20, 2019
@Twizty
typelevel#3141 Removed changes from reduceMapK
c63b8bc
LukaJCB pushed a commit that referenced this issue Dec 10, 2019
@Twizty @LukaJCB
Issue 3141 (#3150)
70c9625 
* #3141 [WIP] Implemented .foldA

* #3141 [WIP] Implemented .reduceA

* #3141 [WIP] Implemented .reduceMapA

* #3141 Refactored

* #3141 Added tests

* #3141 Fixed 2.13

* #3141 Added link to the issue at simulacrum

* #3141 Fixed docs

* #3141 Formatted

* #3141 Refactored

* #3141 Changed .reduceMap signature

* #3141 Removed noop on .reduceMapA

* #3141 Fixed docs

* #3141 Removed changes from reduceMapK
@travisbrown travisbrown mentioned this issue Dec 10, 2019
Open
@travisbrown
Copy link
Contributor

Done in #3150 and some follow-ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@travisbrown @Twizty @LukaJCB