Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate the types of implicit instances #4

Closed
non opened this issue Jan 30, 2015 · 4 comments
Closed

Annotate the types of implicit instances #4

non opened this issue Jan 30, 2015 · 4 comments

Comments

@non
Copy link
Contributor

non commented Jan 30, 2015

As @retronym says:

I'd suggest to annotate the types of implicits as a rule around the code base.
It is too easy to have overly-specific structural types inferred for
implicit val fooInstance = new A with B { .... }

@milessabin
Copy link
Member

Yes, definitely.

@adelbertc
Copy link
Contributor

Are there places where this isn't being done? grep-ed around the codebase and everything seems to be annotated. That, or I'm bad at grep, which is quite possible.

@non
Copy link
Contributor Author

non commented Feb 6, 2015

I think previously there were. They may all be fixed now.

@ceedubs
Copy link
Contributor

ceedubs commented Feb 6, 2015

I think they are all fixed except some places where we have simulacrum TODOs like here.

@non non closed this as completed in 4b52770 Feb 6, 2015
non added a commit that referenced this issue Feb 6, 2015
Annotate types of remaining implicit instances, closes #4
@non non removed the ready label Feb 6, 2015
adelbertc pushed a commit that referenced this issue Aug 23, 2016
Add Scala Exercises to list of resources for learners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants