Use Future#successful in pureEval when possible #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Now` already has performed the work required to calculate the result value, we can lift the result into a Future using `Future#successful` instead of unwrapping the `Now` inside the block run by the `Future` (which potentially has to use another thread).
|
👍 looks good to me as long as the build passes |
Current coverage is 82.00%
@@ master #1019 diff @@
==========================================
Files 215 215
Lines 2704 2705 +1
Methods 2639 2637 -2
Messages 0 0
Branches 60 63 +3
==========================================
+ Hits 2217 2218 +1
Misses 487 487
Partials 0 0
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Nowalready has performed the work required to calculate the result value, we can lift the result into a Future usingFuture#successfulinstead of unwrapping theNowinside the block run by theFuture(which potentially has to use another thread).