Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uber import in docs. (#1026) #1104

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Use uber import in docs. (#1026) #1104

merged 1 commit into from
Jun 9, 2016

Conversation

cranst0n
Copy link
Contributor

@cranst0n cranst0n commented Jun 9, 2016

No description provided.

@non
Copy link
Contributor

non commented Jun 9, 2016

Love it! Thanks so much. 👍

@codecov-io
Copy link

codecov-io commented Jun 9, 2016

Current coverage is 88.92%

Merging #1104 into master will not change coverage

@@             master      #1104   diff @@
==========================================
  Files           226        226          
  Lines          2917       2917          
  Methods        2867       2867          
  Messages          0          0          
  Branches         48         48          
==========================================
  Hits           2594       2594          
  Misses          323        323          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 88cbe95...044e573

@ceedubs
Copy link
Contributor

ceedubs commented Jun 9, 2016

Oh fantastic @cranst0n. Thanks a bunch! Based on repeated Gitter questions, I think this will help a lot of people.

@ceedubs ceedubs merged commit e78666f into typelevel:master Jun 9, 2016
@cranst0n
Copy link
Contributor Author

cranst0n commented Jun 9, 2016

@ceedubs @non

I forgot to mention an issue that came up when making these changes. Specifically in optiont.md in the tut docs.

When I replaced the respective instances of import cats.std.future._ tut fails to compile it:

[tut] *** Error reported at optiont.md:69
<console>:25: error: ambiguous implicit values:
 both value catsStdBimonadForFunction0 in trait Function0Instances of type => cats.Bimonad[Function0]
 and value catsStdInstancesForList in trait ListInstances of type => cats.Traverse[List] with cats.MonadCombine[List] with cats.MonadRec[List] with cats.CoflatMap[List]
 match expected type cats.Applicative[F]
         l <- OptionT.fromOption(lastnameO)

I didn't make the change because of this reason but I suppose it should be addressed in some way?

@ceedubs
Copy link
Contributor

ceedubs commented Jun 9, 2016

@cranst0n oh thanks for the heads up. It looks like after changing the imports you need to change that line to OptionT.fromOption[Future](lastnameO). I'm not really sure why that is. I'd be inclined to go ahead and change to the uber imports and do that anyway.

ceedubs added a commit to ceedubs/cats that referenced this pull request Jun 11, 2016
This (strangely?) required adding an explicit type parameter.

Follow up to
typelevel#1104 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants