Yet some more uniquifying of implicit names #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the last of the implicit names for typelevel#1061.
Current coverage is 88.68%@@ master #1122 diff @@
==========================================
Files 227 227
Lines 2992 2987 -5
Methods 2943 2939 -4
Messages 0 0
Branches 47 46 -1
==========================================
- Hits 2651 2649 -2
+ Misses 341 338 -3
Partials 0 0
|
| new Predicate[A] { | ||
| def apply(a: A) = ev.neqv(a, A.empty) | ||
| } | ||
|
|
||
| lazy val proved = Prop(Result(status = Proof)) |
There was a problem hiding this comment.
Just curious what makes this one redundant?
There was a problem hiding this comment.
Oh good catch I meant to ask people about this.
@non @johnynek: this seemed a little suspicious to me. I can understand the parameters being implicit, but why was the def itself implicit? It wasn't actually used in cats and didn't appear to be in algebra, so I removed it. Is this something that should be kept around?
There was a problem hiding this comment.
Let's remove it. I'm not sure what I was thinking.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the last of the implicit names for #1061.
@kailuowang would you be willing to review this?