Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/doc overhaul wip #1145

Merged
merged 8 commits into from
Jun 27, 2016
Merged

Topic/doc overhaul wip #1145

merged 8 commits into from
Jun 27, 2016

Conversation

non
Copy link
Contributor

@non non commented Jun 18, 2016

This is a doc overhaul @ceedubs and I were working on.

I'm not 100% sure it's ready to go but I'm pushing this for early review. Suggestions, editions, and additions are all very welcome. /cc @ceedubs


(We also plan to support [Miniboxing](http://scala-miniboxing.org) in a branch.)

Currently Cats is experimenting with providing laziness via a type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before This design may change

@OlivierBlanvillain
Copy link
Contributor

I really like the shorter readme. LGTM 👍

@codecov-io
Copy link

codecov-io commented Jun 18, 2016

Current coverage is 88.80%

Merging #1145 into master will not change coverage

@@             master      #1145   diff @@
==========================================
  Files           228        228          
  Lines          3028       3028          
  Methods        2980       2980          
  Messages          0          0          
  Branches         46         46          
==========================================
  Hits           2689       2689          
  Misses          339        339          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by caf9901...db8223c

@ceedubs
Copy link
Contributor

ceedubs commented Jun 19, 2016

👍 I think there's more work to do, but I think this is a step in the right direction.

Initially Cats will support the following modules:

* `macros`: Macro definitions needed for `core` and other projects.
* `core`: Definitions for widely-used type classes and data types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about taking the opportunity to add kernel and bench?

Cats consists of sub modules, both to keep the size of the
artifacts down and also to avoid unnecessarily tight coupling between
type classes and data types.

 Cats supports the following modules:

* `core`: Definitions for widely-used type classes and data types.
* `bench`: Benchmarking suites. Not published. 
* `free`: Free structures such as the free monad, and supporting type classes.
* `kernel`: Definitions for the basic algebraic type classes 
* `kernel-laws`: The encoded laws for type classes defined in `kernel`, exported to assist third-party testing.
* `laws`: The encoded laws for type classes defined in `core`, exported to assist third-party testing.
* `macros`: Macro definitions needed for `core` and other projects.
* `tests`: Verifies the laws, and runs any other tests. Not published.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@non are you planning on adding this? I'm happy to add it in a followup PR if that's easier for you.

@ceedubs
Copy link
Contributor

ceedubs commented Jun 27, 2016

I'm going to go ahead and merge this and we can follow up with further items in separate PRs. Thanks @non!

@ceedubs ceedubs merged commit 3402608 into typelevel:master Jun 27, 2016
ceedubs added a commit to ceedubs/cats that referenced this pull request Jun 27, 2016
@kailuowang
Copy link
Contributor

@ceedubs I can create a PR on the design change.

@ceedubs
Copy link
Contributor

ceedubs commented Jun 27, 2016

@kailuowang @non I created #1162 for the module changes in the design doc (sorry @kailuowang it was before your message, or at least before I saw it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants