Add johnynek as a maintainer #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@johnynek's Cats contributions started fairly recently, but @johnynek was a big part of the algebra effort that led to cats-kernel and has contributed some nice changes and feedback since the creation of cats-kernel. Like @non, @johnynek is a person who is performance-conscious, and I think that Cats could benefit from this area of knowledge/awareness.
|
👍 |
Current coverage is 88.79%@@ master #1180 diff @@
==========================================
Files 233 233
Lines 3079 3079
Methods 3025 3025
Messages 0 0
Branches 51 51
==========================================
Hits 2734 2734
Misses 345 345
Partials 0 0
|
|
I feel honored and welcomed! Looking forward to helping with cats! 👍 |
|
Regardless of what codecov.io says, I'm sure that merging this PR will improve coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnynek's Cats contributions started fairly recently, but @johnynek was a big part of the algebra effort that led to cats-kernel and has contributed some nice changes and feedback since the creation of cats-kernel. Like @non, @johnynek is a person who is performance-conscious, and I think that Cats could benefit from this area of knowledge/awareness.
@johnynek thanks for the great work. Add a 👍 if you would like to be added as a maintainer.
If anyone has reason to believe that this candidate's conduct does not align with typelevel's code of conduct or goal of an inclusive, welcoming and safe environment; please contact a typelevel member (contact information is provided at the bottom of the code of conduct) via email or private Gitter message.