Remove MonadFilter.filterM #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves typelevel#1054. This simply removes `MonadFilter.filterM` to prevent confusion due to this `filterM` being different than that from Haskell or Scalaz. This version of `filterM` doesn't seem particularly useful to me. The only type that comes to mind for which this might be useful is `Option`, and it's pretty easy to come up with a more straightforward implementation for the `Option` case. A more general solution for `filterM` is provided by typelevel#1148, but so far there doesn't seem to be any interest in that proposal, so I don't want it to hold up resolving
Current coverage is 89.25%@@ master #1202 diff @@
==========================================
Files 234 234
Lines 3137 3135 -2
Methods 3083 3079 -4
Messages 0 0
Branches 52 53 +1
==========================================
+ Hits 2797 2798 +1
+ Misses 340 337 -3
Partials 0 0
|
|
👍 LGTM |
|
👍 While it is not hard to implement, it might be interesting to keep if it is both useful and there can be specialized implementations that are more efficient that flatMaps + empty, but it is hard for me to see any examples of that right away. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1054.
This simply removes
MonadFilter.filterMto prevent confusion due tothis
filterMbeing different than that from Haskell or Scalaz.This version of
filterMdoesn't seem particularly useful to me. Theonly type that comes to mind for which this might be useful is
Option,and it's pretty easy to come up with a more straightforward
implementation for the
Optioncase. A more general solution forfilterMis provided by #1148, but so far there doesn't seem to be anyinterest in that proposal, so I don't want it to hold up resolving #1054.