Add tell method to WriterT #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also add `tell` and `value` methods to the `Writer` object to conveniently create `Writer` instances.
|
This is a replacement for #1205, where I tried to do too many things at once and got tripped up on naming. |
Current coverage is 89.18%@@ master #1207 diff @@
==========================================
Files 234 234
Lines 3141 3144 +3
Methods 3084 3085 +1
Messages 0 0
Branches 55 57 +2
==========================================
+ Hits 2802 2804 +2
- Misses 339 340 +1
Partials 0 0
|
| w2.tell("bar") should === (Writer("foobar", 3)) | ||
| } | ||
|
|
||
| test("MonadWriter's tell is consistent with write") { |
There was a problem hiding this comment.
This probably should be "... is consistent with tell" ?
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also add
tellandvaluemethods to theWriterobject toconveniently create
Writerinstances.