Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bisequence and bimap examples #1238

Merged
merged 2 commits into from
Aug 7, 2016
Merged

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jul 28, 2016

This was originally part of #1194, but since it's looking uncertain
whether or not that will go forward, I'm submitting it separately.

This was originally part of typelevel#1194, but since it's looking uncertain
whether or not that will go forward, I'm separating it to here.
@adelbertc
Copy link
Contributor

👍 on Travis green

@codecov-io
Copy link

codecov-io commented Jul 28, 2016

Current coverage is 90.46% (diff: 100%)

Merging #1238 into master will increase coverage by 0.32%

@@             master      #1238   diff @@
==========================================
  Files           243        243          
  Lines          3284       3334    +50   
  Methods        3228       3281    +53   
  Messages          0          0          
  Branches         53         53          
==========================================
+ Hits           2960       3016    +56   
+ Misses          324        318     -6   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 5b35e84...50c3053

@fthomas
Copy link
Member

fthomas commented Jul 28, 2016

@ceedubs All result variables have the name res0 which could be confusing. Could you rename them to res0, res1, res2, etc. so that the example looks like a real REPL session?

@ceedubs
Copy link
Contributor Author

ceedubs commented Jul 28, 2016

Good catch @fthomas. Fixed.

@ceedubs ceedubs closed this Aug 3, 2016
@ceedubs ceedubs reopened this Aug 3, 2016
@fthomas
Copy link
Member

fthomas commented Aug 7, 2016

👍

@fthomas fthomas merged commit f212a12 into typelevel:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants