-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SBT and SBT plugin versions #1258
Conversation
Looks like build is going to fail. but #1256 should fix build. Otherwise changes look good to me. 👍 |
@kailuowang Great, thanks—I'll rebase after that's merged. (For the record |
@travisbrown thanks for the hint. I tried the same approach in this PR #1257 but it failed pretty miserably (maybe travis just doesn't have that much memory? ) |
@kailuowang -I understood Travis limitation in terms of memory to be 3G. From Travis FAQ, though don't know how up to date that is.
|
6bb8a7b
to
67eacc7
Compare
Current coverage is 90.13% (diff: 100%)@@ master #1258 diff @@
==========================================
Files 243 243
Lines 3285 3285
Methods 3231 3231
Messages 0 0
Branches 51 51
==========================================
Hits 2961 2961
Misses 324 324
Partials 0 0
|
Just rebased this to try out #1256 with the updates. |
👍 |
1 similar comment
👍 |
I just noticed while working on #1253 that some of these versions are out-of-date. I ran the benchmarks locally to confirm that the sbt-jmh update doesn't break anything.