Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SBT and SBT plugin versions #1258

Merged
merged 2 commits into from
Aug 3, 2016

Conversation

travisbrown
Copy link
Contributor

I just noticed while working on #1253 that some of these versions are out-of-date. I ran the benchmarks locally to confirm that the sbt-jmh update doesn't break anything.

@kailuowang
Copy link
Contributor

kailuowang commented Aug 2, 2016

Looks like build is going to fail. but #1256 should fix build. Otherwise changes look good to me. 👍

@travisbrown
Copy link
Contributor Author

@kailuowang Great, thanks—I'll rebase after that's merged. (For the record sbt validate passes locally if I bump the memory in .jvmopts.)

@kailuowang
Copy link
Contributor

@travisbrown thanks for the hint. I tried the same approach in this PR #1257 but it failed pretty miserably (maybe travis just doesn't have that much memory? )

@mikejcurry
Copy link
Contributor

@kailuowang -I understood Travis limitation in terms of memory to be 3G. From Travis FAQ, though don't know how up to date that is.

What hardware are my tests running on?
We use dedicated hardware to ensure full speed for your tests. You have 3GB of memory and up to 2 cores available. Your tests are running directly off SSDs with the most common databases optimized to run off RAM disks.

@codecov-io
Copy link

codecov-io commented Aug 3, 2016

Current coverage is 90.13% (diff: 100%)

Merging #1258 into master will not change coverage

@@             master      #1258   diff @@
==========================================
  Files           243        243          
  Lines          3285       3285          
  Methods        3231       3231          
  Messages          0          0          
  Branches         51         51          
==========================================
  Hits           2961       2961          
  Misses          324        324          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update d8e2671...67eacc7

@travisbrown
Copy link
Contributor Author

Just rebased this to try out #1256 with the updates.

@johnynek
Copy link
Contributor

johnynek commented Aug 3, 2016

👍

1 similar comment
@fthomas
Copy link
Member

fthomas commented Aug 3, 2016

👍

@fthomas fthomas merged commit 6307ddc into typelevel:master Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants