Adding MonadRec for Kleisli #1279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.56% (diff: 100%)@@ master #1279 diff @@
==========================================
Files 243 243
Lines 3285 3295 +10
Methods 3228 3236 +8
Messages 0 0
Branches 55 56 +1
==========================================
+ Hits 2975 2984 +9
- Misses 310 311 +1
Partials 0 0
|
|
|
||
| def local[B](f: A => A)(fa: Kleisli[F, A, B]): Kleisli[F, A, B] = | ||
| Kleisli(f.andThen(fa.run)) | ||
| implicit def catsDataMonadRecForKleisli[F[_], A](implicit ev0: Monad[F], ev1: MonadRec[F]): MonadRec[Kleisli[F, A, ?]] = |
There was a problem hiding this comment.
I am curious why we need evidences for both Monad[F] and MonadRec[F], since MonadRec[F] extends Monad?
There was a problem hiding this comment.
Should only need MonadRec[F] since that implies Monad[F]. And for single implicit parameters I believe the Cats style is:
catsDataMonadRecForKleisli[F[_], A](implicit F: Monad[F]): MonadRec[Kleisli[F, A, ?]] = ...
|
it might be worthwhile to wait on #1280 |
|
@zainab-ali could you review #1280 and see if you think I have correctly implemented this there? I did add tests (and stack safety tests). |
|
@zainab-ali shall we close this one given that #1280 is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
MonadRecinstance forKleisli