Partial revert of #1289 #1306
Merged
Partial revert of #1289 #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All APIs that are present in 0.6.x continue to use `Xor`. New additions, notably FlatMapRec stuff, use `Either`.
| @@ -251,7 +251,7 @@ import simulacrum.typeclass | |||
| /** | |||
| * Behaves like sequence_, but uses [[Unapply]] to find the | |||
| * [[Applicative]] instance for `G` - used when `G` is a | |||
| * type constructor with two or more parameters such as [[scala.util.Either]] | |||
| * type constructor with two or more parameters such as `scala.util.Either` | |||
There was a problem hiding this comment.
For some reason validate was giving me "Could not find any members to link for "scala.util.Either" so I went for the easy way out.
There was a problem hiding this comment.
I totally endorse this. I may-or-may-not have made a snarky tweet about Scaladoc today related to this.
|
👍 Thanks @adelbertc ! |
Current coverage is 90.60% (diff: 96.96%)@@ master #1306 diff @@
==========================================
Files 235 235
Lines 3607 3608 +1
Methods 3549 3548 -1
Messages 0 0
Branches 54 56 +2
==========================================
+ Hits 3268 3269 +1
Misses 339 339
Partials 0 0
|
|
👍 |
This was referenced Aug 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All APIs that are present in 0.6.x continue to use
Xor. New additions, notably FlatMapRec stuff, useEither.