-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lift to FunctionK #1352
Add lift to FunctionK #1352
Conversation
a5cb3dc
to
f9dfea0
Compare
Everything passes except some style assertions, such as using null. |
8a3f8bc
to
0f8578e
Compare
Thanks! Would you mind writing some Scaladoc to explain what the macro does, how to use it, etc.? I think it will be relatively hard for casual users to look at this and understand how to use it. |
Current coverage is 91.72% (diff: 88.23%)@@ master #1352 diff @@
==========================================
Files 237 238 +1
Lines 3571 3588 +17
Methods 3505 3520 +15
Messages 0 0
Branches 65 67 +2
==========================================
+ Hits 3276 3291 +15
- Misses 295 297 +2
Partials 0 0
|
Less boilerplate for |
Do I need to fix the code coverage issues for this PR? I'm not entirely sure how I'd be able to provide coverage for some of the "internal" methods to the macro. |
@andyscott I think it's fine -- I'm not sure if those error message can be hit, but I'm glad you're providing an error message in case someone does hit them. LGTM 👍 |
👍 |
Quick attempt at providing a
lift
method forFunctionK
, by means of a macro.In my local testing, this works for
Free
and other more complicated types if you've enabled some form of the SI-2712 fix.Thoughts?