UUID instances #1399
Merged
UUID instances #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.69% (diff: 100%)@@ master #1399 diff @@
==========================================
Files 240 242 +2
Lines 3610 3614 +4
Methods 3546 3550 +4
Messages 0 0
Branches 63 63
==========================================
+ Hits 3310 3314 +4
Misses 300 300
Partials 0 0
|
Current coverage is 91.69% (diff: 100%)@@ master #1399 diff @@
==========================================
Files 240 242 +2
Lines 3610 3614 +4
Methods 3546 3546
Messages 0 0
Branches 63 67 +4
==========================================
+ Hits 3310 3314 +4
Misses 300 300
Partials 0 0
|
johnynek
requested changes
Oct 5, 2016
| implicit val catsKernelStdOrderForUUID: Order[UUID] = new UUIDOrder | ||
| } | ||
|
|
||
| class UUIDOrder extends Order[UUID] { |
There was a problem hiding this comment.
I wonder if you would be willing to add fromComparable to object Order similar to the Show.fromToString, and use it here. So, it would be a method like:
object Order {
def fromComparable[T <: Comparable]: Order[T] = new Order[T] {
...
}
}There was a problem hiding this comment.
OK, hopefully I'll have some time for that during the weekend.
| package object uuid extends UUIDInstances | ||
|
|
||
| trait UUIDInstances { | ||
| implicit val catsKernelStdOrderForUUID: Order[UUID] = new UUIDOrder |
There was a problem hiding this comment.
if you do the below, you can do = Order.fromComparable[UUID]
|
👍 |
johnynek
approved these changes
Oct 18, 2016
|
Thanks @durban, can you add a |
|
I agree with @peterneyens. Otherwise, LGTM too! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order[UUID]Show[UUID]