Rename interpret and replace ~> #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
after this is merged, I'll update #1411 |
|
@johnynek This PR's against that branch, so if you click merge that'll happen automatically. :) |
|
overlooked that! |
johnynek
added a commit
that referenced
this pull request
Oct 26, 2016
* Add foldMap/compile FunctionK to Free companion * Rename interpret and replace ~> (#1433) * Use FunctionK instead of ~> alias in FreeT * Rename interpret in FreeT to compile for consistency with Free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that I'm impatient or anything, but here are the changes suggested by @non in @johnynek's #1411, which is currently the last thing we've said we want for the 0.8.0 release.
I went with
FunctionKinstead of~>because there are a lot ofFunctionKs in cats-free and no~>s outside of FreeT.scala.