Fix tut in monad doc #1445
Merged
Fix tut in monad doc #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.19% (diff: 100%)@@ master #1445 diff @@
==========================================
Files 242 242
Lines 3615 3615
Methods 3543 3543
Messages 0 0
Branches 72 72
==========================================
Hits 3333 3333
Misses 282 282
Partials 0 0
|
|
I've noticed this in my own tut files from time to time.. hopefully this is the last of them. @tpolecat do you know what might cause the old file to still pass tut? Might be lack of closing brace makes tut think there's still input and if the file just doesn't close tut is fine with that? |
|
@adelbertc yeah Cody discovered that a while ago and I haven't fixed it yet, obviously. tpolecat/tut#65 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure of the underlying machinary, but it turned out that the missing closing brace has been causing mysterious tut passing found on #1444.