Show instance for scala.Symbol #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.21% (diff: 100%)@@ master #1484 diff @@
==========================================
Files 242 243 +1
Lines 3609 3610 +1
Methods 3540 3491 -49
Messages 0 0
Branches 69 119 +50
==========================================
+ Hits 3328 3329 +1
Misses 281 281
Partials 0 0
|
|
👍 I don't think any instances being missing from |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes sure, that cats.instances.AllInstances contains the Symbol instances.
BTW, there are other instances, which are not in AllInstances (and as a result, are not in scope after doing
import cats.implicits._), e.g., Eq[BitSet]. Is this intentional?