Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scaladoc for Eval methods Unit, True, False, Zero, One #1545

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

sullivan-
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 1, 2017

Codecov Report

Merging #1545 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1545   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files         246      246           
  Lines        3885     3885           
  Branches      132      133    +1     
=======================================
  Hits         3593     3593           
  Misses        292      292
Impacted Files Coverage Δ
core/src/main/scala/cats/Eval.scala 97.1% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d8858...557db70. Read the comment docs.

@johnynek
Copy link
Contributor

johnynek commented Mar 1, 2017

👍

@@ -206,15 +206,43 @@ object Eval extends EvalInstances {
new Eval.Call[A](a _) {}

/**
* Static Eval instances for some common values.
* Static Eval instances for common value `Unit`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instances -> instance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! fixed it

@kailuowang
Copy link
Contributor

Thanks very much!

@kailuowang kailuowang merged commit e28f9f3 into typelevel:master Mar 2, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-MF Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants