-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename prod coproduct #1589
Rename prod coproduct #1589
Conversation
thanks for doing this! I think this is a win for consistency and readability prior to 1.0. 👍 |
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 249 249
Lines 3974 3974
Branches 131 131
=======================================
Hits 3673 3673
Misses 301 301
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Bikeshedding, but |
@adelbertc I don't dislike |
yeahhhhh i just don't like having numbers in names for some reason.. but oh well 👍 |
@adelbertc I thought |
fixes #1582
Note that this should be a fairly straightforward PR to review. However, github failed to render the diff in renamed files correctly - it displays the diff as a whole file removed and a new file. To overcome this, you might want to review the two commits separately.